Skip to content


Subversion checkout URL

You can clone with
Download ZIP
Browse files

Fixed #7289 -- Made ModelForms behave like Forms in the sense that Field

objects don't appear as attributes on the final form instance. They continue to
appear as elements of the form_instance.fields mapping.

If you were relying on ModelForms having fields as attributes, then this will
be slightly backwards incompatible. However, normal template usage will see no
change at all.

Patch from Daniel Pope.

git-svn-id: bcc190cf-cafb-0310-a4f2-bffc1f526a37
  • Loading branch information...
commit 7e9a22aae7a363a60d6aa2a27a06b1fd01d6ac13 1 parent ec8848d
@malcolmt malcolmt authored
Showing with 1 addition and 1 deletion.
  1. +1 −1  django/forms/
2  django/forms/
@@ -163,6 +163,7 @@ def __new__(cls, name, bases, attrs):
except NameError:
# We are defining ModelForm itself.
parents = None
+ declared_fields = get_declared_fields(bases, attrs, False)
new_class = super(ModelFormMetaclass, cls).__new__(cls, name, bases,
if not parents:
@@ -170,7 +171,6 @@ def __new__(cls, name, bases, attrs):
if 'media' not in attrs: = media_property(new_class)
- declared_fields = get_declared_fields(bases, attrs, False)
opts = new_class._meta = ModelFormOptions(getattr(new_class, 'Meta', None))
if opts.model:
# If a model is defined, extract form fields from it.

0 comments on commit 7e9a22a

Please sign in to comment.
Something went wrong with that request. Please try again.