Skip to content

HTTPS clone URL

Subversion checkout URL

You can clone with
or
.
Download ZIP
Browse files

Fixed #9029 -- Allow use of fieldname_id with get_or_create. Thanks t…

…o aaron and mrmachine.

git-svn-id: http://code.djangoproject.com/svn/django/trunk@15156 bcc190cf-cafb-0310-a4f2-bffc1f526a37
  • Loading branch information...
commit 81e05a418dc6f347d9627373288e773c477a9fe0 1 parent 32a344d
@andrewgodwin andrewgodwin authored
View
8 django/db/models/query.py
@@ -369,9 +369,13 @@ def get_or_create(self, **kwargs):
assert kwargs, \
'get_or_create() must be passed at least one keyword argument'
defaults = kwargs.pop('defaults', {})
+ lookup = kwargs.copy()
+ for f in self.model._meta.fields:
+ if f.column in lookup:
+ lookup[f.name] = lookup.pop(f.column)
try:
self._for_write = True
- return self.get(**kwargs), False
+ return self.get(**lookup), False
except self.model.DoesNotExist:
try:
params = dict([(k, v) for k, v in kwargs.items() if '__' not in k])
@@ -384,7 +388,7 @@ def get_or_create(self, **kwargs):
except IntegrityError, e:
transaction.savepoint_rollback(sid, using=self.db)
try:
- return self.get(**kwargs), False
+ return self.get(**lookup), False
except self.model.DoesNotExist:
raise e
View
11 tests/regressiontests/get_or_create_regress/tests.py
@@ -21,7 +21,7 @@ def test_related(self):
# Add an author to the book.
ed, created = book.authors.get_or_create(name="Ed")
self.assertTrue(created)
- # Book should have one author.
+ # The book should have one author.
self.assertEqual(book.authors.count(), 1)
# Try get_or_create again, this time nothing should be created.
@@ -51,3 +51,12 @@ def test_related(self):
# Now Ed has two Books, Fred just one.
self.assertEqual(ed.books.count(), 2)
self.assertEqual(fred.books.count(), 1)
+
+ # Use the publisher's primary key value instead of a model instance.
+ _, created = ed.books.get_or_create(name='The Great Book of Ed', publisher_id=p.id)
+ self.assertTrue(created)
+ # Try get_or_create again, this time nothing should be created.
+ _, created = ed.books.get_or_create(name='The Great Book of Ed', publisher_id=p.id)
+ self.assertFalse(created)
+ # The publisher should have three books.
+ self.assertEqual(p.books.count(), 3)

0 comments on commit 81e05a4

Please sign in to comment.
Something went wrong with that request. Please try again.