Skip to content

HTTPS clone URL

Subversion checkout URL

You can clone with HTTPS or Subversion.

Download ZIP
Browse files

Fixed #15266 -- Applied login_required decorator to password_change_d…

…one view. Thanks, lasko.

git-svn-id: http://code.djangoproject.com/svn/django/trunk@16454 bcc190cf-cafb-0310-a4f2-bffc1f526a37
  • Loading branch information...
commit 821d8aaaaad3f4d11f29eb54a7812f363b5f07cb 1 parent 650739e
Jannis Leidel jezdez authored
Showing with 18 additions and 0 deletions.
  1. +17 −0 django/contrib/auth/tests/views.py
  2. +1 −0  django/contrib/auth/views.py
17 django/contrib/auth/tests/views.py
View
@@ -193,6 +193,23 @@ def test_password_change_succeeds(self):
self.fail_login()
self.login(password='password1')
+ def test_password_change_done_succeeds(self):
+ self.login()
+ response = self.client.post('/password_change/', {
+ 'old_password': 'password',
+ 'new_password1': 'password1',
+ 'new_password2': 'password1',
+ }
+ )
+ self.assertEqual(response.status_code, 302)
+ self.assertTrue(response['Location'].endswith('/password_change/done/'))
+
+ def test_password_change_done_fails(self):
+ response = self.client.get('/password_change/done/')
+ self.assertEqual(response.status_code, 302)
+ self.assertTrue(response['Location'].endswith('/login/?next=/password_change/done/'))
+
+
class LoginTest(AuthViewsTestCase):
def test_current_site_in_context_after_login(self):
1  django/contrib/auth/views.py
View
@@ -257,6 +257,7 @@ def password_change(request,
return TemplateResponse(request, template_name, context,
current_app=current_app)
+@login_required
def password_change_done(request,
template_name='registration/password_change_done.html',
current_app=None, extra_context=None):
Please sign in to comment.
Something went wrong with that request. Please try again.