Skip to content

HTTPS clone URL

Subversion checkout URL

You can clone with
or
.
Download ZIP
Browse files

Changed generic admin changelist to order by ID if no other ordering …

…is specified, rather than raising a scary exception

git-svn-id: http://code.djangoproject.com/svn/django/trunk@128 bcc190cf-cafb-0310-a4f2-bffc1f526a37
  • Loading branch information...
commit 82f04688014ff309e1744d76f0cc09ad69fc8db8 1 parent cfcf3ca
@adrianholovaty adrianholovaty authored
Showing with 6 additions and 3 deletions.
  1. +6 −3 django/views/admin/main.py
View
9 django/views/admin/main.py
@@ -99,12 +99,15 @@ def change_list(request, app_label, module_name):
if params.has_key(PAGE_VAR):
del params[PAGE_VAR]
# For ordering, first check the "ordering" parameter in the admin options,
- # then check the object's default ordering. Finally, look for manually-
- # specified ordering from the query string.
+ # then check the object's default ordering. If neither of those exist,
+ # order descending by ID by default. Finally, look for manually-specified
+ # ordering from the query string.
if lookup_opts.admin.ordering is not None:
order_field, order_type = lookup_opts.admin.ordering
- else:
+ elif lookup_opts.ordering:
order_field, order_type = lookup_opts.ordering[0]
+ else:
+ order_field, order_type = lookup_opts.pk.name, 'DESC'
if params.has_key(ORDER_VAR):
try:
order_key = int(params[ORDER_VAR])
Please sign in to comment.
Something went wrong with that request. Please try again.