Browse files

Sped up the create_permissions signal handler (and thus the test suit…

…e) by restructuring its queries.

git-svn-id: bcc190cf-cafb-0310-a4f2-bffc1f526a37
  • Loading branch information...
1 parent d8e311c commit 877033b479ed4252ed4d40714a70fcb4a85c641f @alex alex committed Nov 4, 2010
Showing with 3 additions and 7 deletions.
  1. +3 −7 django/contrib/auth/management/
@@ -26,21 +26,17 @@ def create_permissions(app, created_models, verbosity, **kwargs):
searched_perms = set()
# The codenames and ctypes that should exist.
ctypes = set()
- codenames = set()
for klass in app_models:
ctype = ContentType.objects.get_for_model(klass)
for perm in _get_all_permissions(klass._meta):
- codenames.add(perm[0])
searched_perms.add((ctype, perm))
- # Find all the Permissions that a) have a content_type for a model we're
- # looking for, and b) have a codename we're looking for. It doesn't need to
- # have both, we have a list of exactly what we want, and it's faster to
- # write the query with fewer conditions.
+ # Find all the Permissions that have a context_type for a model we're
+ # looking for. We don't need to check for codenames since we already have
+ # a list of the ones we're going to create.
all_perms = set(auth_app.Permission.objects.filter(
- codename__in=codenames
"content_type", "codename"

0 comments on commit 877033b

Please sign in to comment.