Skip to content
This repository

HTTPS clone URL

Subversion checkout URL

You can clone with HTTPS or Subversion.

Download ZIP
Browse code

Revert "[1.5.x] Silenced last sporadic failure on 1.5."

This reverts commit 6a708cd.

Reverted since it only moved the failures to some other tests and it apperently
only worked by accident. Patched selenium for now to include:
SeleniumHQ/selenium#118
which seems to be the root cause for sporadic extra requests to the live server,
which then cause all sorts of issues.
  • Loading branch information...
commit 87c8de2a06433a6d87a85a8f79e378feafa5ed46 1 parent 72f7932
Florian Apolloner authored September 18, 2013
6  tests/regressiontests/forms/tests/widgets.py
@@ -1116,12 +1116,6 @@ def test_textarea_trailing_newlines(self):
1116 1116
         article = Article.objects.get(pk=article.pk)
1117 1117
         # Should be "\nTst\n" after #19251 is fixed
1118 1118
         self.assertEqual(article.content, "\r\nTst\r\n")
1119  
-        # So now it's becoming obscure; we do have threading issues here, so this
1120  
-        # test fails sometimes for sqlite, I could only ever witness it on jenkins.
1121  
-        # As long as 1.5 is supported we manually "fix" this test by quitting
1122  
-        # selenium. No idea why closing the browser window isn't enough, but hey…
1123  
-        self.selenium.quit()
1124  
-        delattr(self.__class__, 'selenium')
1125 1119
 
1126 1120
 
1127 1121
 @python_2_unicode_compatible

0 notes on commit 87c8de2

Please sign in to comment.
Something went wrong with that request. Please try again.