Skip to content
This repository

HTTPS clone URL

Subversion checkout URL

You can clone with HTTPS or Subversion.

Download ZIP
Browse code

Fixed #4148 -- Changed the way attachments are served to IE to avoid …

…some

caching and header-related bugs there. Only comes into play when Internet
Explorer is the user-agent.

Patch from Michael Axiak, with testing from Axis_of_Entropy and Karen Tracey.


git-svn-id: http://code.djangoproject.com/svn/django/trunk@7856 bcc190cf-cafb-0310-a4f2-bffc1f526a37
  • Loading branch information...
commit 8975bba742151a6a3164d5c7df7d793f12a7c5c1 1 parent 6048389
Malcolm Tredinnick authored July 07, 2008
8  django/core/handlers/base.py
@@ -6,8 +6,12 @@
6 6
 
7 7
 class BaseHandler(object):
8 8
     # Changes that are always applied to a response (in this order).
9  
-    response_fixes = [http.fix_location_header,
10  
-            http.conditional_content_removal]
  9
+    response_fixes = [
  10
+        http.fix_location_header,
  11
+        http.conditional_content_removal,
  12
+        http.fix_IE_for_attach,
  13
+        http.fix_IE_for_vary,
  14
+    ]
11 15
 
12 16
     def __init__(self):
13 17
         self._request_middleware = self._view_middleware = self._response_middleware = self._exception_middleware = None
51  django/http/utils.py
@@ -31,3 +31,54 @@ def conditional_content_removal(request, response):
31 31
     if request.method == 'HEAD':
32 32
         response.content = ''
33 33
     return response
  34
+
  35
+def fix_IE_for_attach(request, response):
  36
+    """
  37
+    This function will prevent Django from serving a Content-Disposition header
  38
+    while expecting the browser to cache it (only when the browser is IE). This
  39
+    leads to IE not allowing the client to download.
  40
+    """
  41
+    if 'MSIE' not in request.META.get('HTTP_USER_AGENT', '').upper():
  42
+        return response
  43
+
  44
+    offending_headers = ('no-cache', 'no-store')
  45
+    if response.has_header('Content-Disposition'):
  46
+        try:
  47
+            del response['Pragma']
  48
+        except KeyError:
  49
+            pass
  50
+        if response.has_header('Cache-Control'):
  51
+            cache_control_values = [value.strip() for value in
  52
+                    response['Cache-Control'].split(',')
  53
+                    if value.strip().lower() not in offending_headers]
  54
+
  55
+            if not len(cache_control_values):
  56
+                del response['Cache-Control']
  57
+            else:
  58
+                response['Cache-Control'] = ', '.join(cache_control_values)
  59
+
  60
+    return response
  61
+
  62
+def fix_IE_for_vary(request, response):
  63
+    """
  64
+    This function will fix the bug reported at
  65
+    http://support.microsoft.com/kb/824847/en-us?spid=8722&sid=global
  66
+    by clearing the Vary header whenever the mime-type is not safe
  67
+    enough for Internet Explorer to handle.  Poor thing.
  68
+    """
  69
+    if 'MSIE' not in request.META.get('HTTP_USER_AGENT', '').upper():
  70
+        return response
  71
+
  72
+    # These mime-types that are decreed "Vary-safe" for IE:
  73
+    safe_mime_types = ('text/html', 'text/plain', 'text/sgml')
  74
+
  75
+    # The first part of the Content-Type field will be the MIME type,
  76
+    # everything after ';', such as character-set, can be ignored.
  77
+    if response['Content-Type'].split(';')[0] not in safe_mime_types:
  78
+        try:
  79
+            del response['Vary']
  80
+        except KeyError:
  81
+            pass
  82
+
  83
+    return response
  84
+

0 notes on commit 8975bba

Please sign in to comment.
Something went wrong with that request. Please try again.