Skip to content

HTTPS clone URL

Subversion checkout URL

You can clone with HTTPS or Subversion.

Download ZIP
Browse files

Fixed #10127 -- Corrected handling of select_related() in annotate() …

…calls. Thanks to Sylvain Pasche <sylvain.pasche@gmail.com> for the report and test case.

git-svn-id: http://code.djangoproject.com/svn/django/trunk@9805 bcc190cf-cafb-0310-a4f2-bffc1f526a37
  • Loading branch information...
commit 8f410a577befddeff8639410a7a85d8e6d1c86e7 1 parent 65ad213
@freakboy3742 freakboy3742 authored
View
4 django/db/models/query.py
@@ -280,8 +280,8 @@ def iterator(self):
for row in self.query.results_iter():
if fill_cache:
- obj, aggregate_start = get_cached_row(self.model, row,
- index_start, max_depth, requested=requested)
+ obj, _ = get_cached_row(self.model, row,
+ index_start, max_depth, requested=requested)
else:
# omit aggregates in object creation
obj = self.model(*row[index_start:aggregate_start])
View
2  django/db/models/sql/query.py
@@ -698,7 +698,7 @@ def get_grouping(self):
"""
qn = self.quote_name_unless_alias
result = []
- for col in self.group_by:
+ for col in self.group_by + self.related_select_cols:
if isinstance(col, (list, tuple)):
result.append('%s.%s' % (qn(col[0]), qn(col[1])))
elif hasattr(col, 'as_sql'):
View
5 tests/regressiontests/aggregation_regress/models.py
@@ -194,6 +194,11 @@ def __unicode__(self):
>>> Book.objects.annotate(num_authors=Count('authors')).order_by('publisher__name', 'name')
[<Book: Practical Django Projects>, <Book: The Definitive Guide to Django: Web Development Done Right>, <Book: Paradigms of Artificial Intelligence Programming: Case Studies in Common Lisp>, <Book: Artificial Intelligence: A Modern Approach>, <Book: Python Web Development with Django>, <Book: Sams Teach Yourself Django in 24 Hours>]
+# Regression for #10127 - Empty select_related() works with annotate
+>>> books = Book.objects.all().filter(rating__lt=4.5).select_related().annotate(Avg('authors__age'))
+>>> sorted([(b.name, b.authors__age__avg) for b in books])
+[(u'Artificial Intelligence: A Modern Approach', 51.5), (u'Practical Django Projects', 29.0), (u'Python Web Development with Django', 30.3...), (u'Sams Teach Yourself Django in 24 Hours', 45.0)]
+
"""
}
Please sign in to comment.
Something went wrong with that request. Please try again.