Skip to content

HTTPS clone URL

Subversion checkout URL

You can clone with
or
.
Download ZIP
Browse files

Moved standard SQL for savepoints in the base backend.

These methods are only called when uses_savepoints = True anyway.
  • Loading branch information...
commit 918f44e3ae650ff124067425d31c9d3deeba2224 1 parent 3bdc7a6
@aaugustin aaugustin authored
View
6 django/db/backends/__init__.py
@@ -863,19 +863,19 @@ def savepoint_create_sql(self, sid):
"uses_savepoints" feature is True. The "sid" parameter is a string
for the savepoint id.
"""
- raise NotImplementedError
+ return "SAVEPOINT %s" % self.quote_name(sid)
def savepoint_commit_sql(self, sid):
"""
Returns the SQL for committing the given savepoint.
"""
- raise NotImplementedError
+ return "RELEASE SAVEPOINT %s" % self.quote_name(sid)
def savepoint_rollback_sql(self, sid):
"""
Returns the SQL for rolling back the given savepoint.
"""
- raise NotImplementedError
+ return "ROLLBACK TO SAVEPOINT %s" % self.quote_name(sid)
def set_time_zone_sql(self):
"""
View
9 django/db/backends/mysql/base.py
@@ -355,15 +355,6 @@ def bulk_insert_sql(self, fields, num_values):
items_sql = "(%s)" % ", ".join(["%s"] * len(fields))
return "VALUES " + ", ".join([items_sql] * num_values)
- def savepoint_create_sql(self, sid):
- return "SAVEPOINT %s" % sid
-
- def savepoint_commit_sql(self, sid):
- return "RELEASE SAVEPOINT %s" % sid
-
- def savepoint_rollback_sql(self, sid):
- return "ROLLBACK TO SAVEPOINT %s" % sid
-
class DatabaseWrapper(BaseDatabaseWrapper):
vendor = 'mysql'
operators = {
View
9 django/db/backends/postgresql_psycopg2/operations.py
@@ -175,15 +175,6 @@ def sequence_reset_sql(self, style, model_list):
style.SQL_TABLE(qn(f.m2m_db_table()))))
return output
- def savepoint_create_sql(self, sid):
- return "SAVEPOINT %s" % sid
-
- def savepoint_commit_sql(self, sid):
- return "RELEASE SAVEPOINT %s" % sid
-
- def savepoint_rollback_sql(self, sid):
- return "ROLLBACK TO SAVEPOINT %s" % sid
-
def prep_for_iexact_query(self, x):
return x
Please sign in to comment.
Something went wrong with that request. Please try again.