Skip to content

HTTPS clone URL

Subversion checkout URL

You can clone with
or
.
Download ZIP
Browse files

Fixed #9136: Do slicing in Oracle with rownum instead of row_number()…

… for a speed improvement. Thanks, Guillaume Taglang.

git-svn-id: http://code.djangoproject.com/svn/django/trunk@9235 bcc190cf-cafb-0310-a4f2-bffc1f526a37
  • Loading branch information...
commit 934025e58d03be49e9fe8bdd54c99d73373137ea 1 parent 9feebb1
@ikelly ikelly authored
Showing with 3 additions and 2 deletions.
  1. +3 −2 django/db/backends/oracle/query.py
View
5 django/db/backends/oracle/query.py
@@ -111,9 +111,10 @@ def as_sql(self, with_limits=True, with_col_aliases=False):
# Wrap the base query in an outer SELECT * with boundaries on
# the "_RN" column. This is the canonical way to emulate LIMIT
# and OFFSET on Oracle.
- sql = 'SELECT * FROM (SELECT ROW_NUMBER() OVER (ORDER BY 1) AS "_RN", "_SUB".* FROM (%s) "_SUB") WHERE "_RN" > %d' % (sql, self.low_mark)
+ high_where = ''
if self.high_mark is not None:
- sql = '%s AND "_RN" <= %d' % (sql, self.high_mark)
+ high_where = 'WHERE ROWNUM <= %d' % (self.high_mark,)
+ sql = 'SELECT * FROM (SELECT ROWNUM AS "_RN", "_SUB".* FROM (%s) "_SUB" %s) WHERE "_RN" > %d' % (sql, high_where, self.low_mark)
return sql, params
Please sign in to comment.
Something went wrong with that request. Please try again.