Skip to content

HTTPS clone URL

Subversion checkout URL

You can clone with HTTPS or Subversion.

Download ZIP
Browse files

Fixed #17339 -- Factor out has_result into database backend.

Thanks jonash.
  • Loading branch information...
commit 95eb68c98fe2dc95277d4e26a0316d856dc868dd 1 parent c0a4894
Tim Graham timgraham authored
Showing with 11 additions and 3 deletions.
  1. +10 −0 django/db/models/sql/compiler.py
  2. +1 −3 django/db/models/sql/query.py
10 django/db/models/sql/compiler.py
View
@@ -750,6 +750,16 @@ def results_iter(self):
yield row
+ def has_results(self):
+ """
+ Backends (e.g. NoSQL) can override this in order to use optimized
+ versions of "query has any results."
+ """
+ # This is always executed on a query clone, so we can modify self.query
+ self.query.add_extra({'a': 1}, None, None, None, None, None)
+ self.query.set_extra_mask(['a'])
+ return bool(self.execute_sql(SINGLE))
+
def execute_sql(self, result_type=MULTI):
"""
Run the query against the database and returns the result(s). The
4 django/db/models/sql/query.py
View
@@ -401,12 +401,10 @@ def get_count(self, using):
def has_results(self, using):
q = self.clone()
q.clear_select_clause()
- q.add_extra({'a': 1}, None, None, None, None, None)
- q.set_extra_mask(['a'])
q.clear_ordering(True)
q.set_limits(high=1)
compiler = q.get_compiler(using=using)
- return bool(compiler.execute_sql(SINGLE))
+ return compiler.has_results()
def combine(self, rhs, connector):
"""
Please sign in to comment.
Something went wrong with that request. Please try again.