Skip to content

HTTPS clone URL

Subversion checkout URL

You can clone with HTTPS or Subversion.

Download ZIP
Browse files

Better error message for calling get_next_by_* on unsaved models.

Patch from Marc Fargas. Fixed #7435.

git-svn-id: http://code.djangoproject.com/svn/django/trunk@13738 bcc190cf-cafb-0310-a4f2-bffc1f526a37
  • Loading branch information...
commit 9802a73e254de90230f8c3574ec46e6761691ba7 1 parent 506d559
Malcolm Tredinnick malcolmt authored
Showing with 4 additions and 0 deletions.
  1. +2 −0  django/db/models/base.py
  2. +2 −0  docs/ref/models/instances.txt
2  django/db/models/base.py
View
@@ -644,6 +644,8 @@ def _get_FIELD_display(self, field):
return force_unicode(dict(field.flatchoices).get(value, value), strings_only=True)
def _get_next_or_previous_by_FIELD(self, field, is_next, **kwargs):
+ if not self.pk:
+ raise ValueError("get_next/get_previous cannot be used on unsaved objects.")
op = is_next and 'gt' or 'lt'
order = not is_next and '-' or ''
param = smart_str(getattr(self, field.attname))
2  docs/ref/models/instances.txt
View
@@ -568,3 +568,5 @@ described in :ref:`Field lookups <field-lookups>`.
Note that in the case of identical date values, these methods will use the ID
as a fallback check. This guarantees that no records are skipped or duplicated.
+
+That also means you cannot use those methods on unsaved objects.
Please sign in to comment.
Something went wrong with that request. Please try again.