Skip to content

HTTPS clone URL

Subversion checkout URL

You can clone with HTTPS or Subversion.

Download ZIP
Browse files

Fixed #2512 -- Fixed SQL error when saving existing empty models.

git-svn-id: http://code.djangoproject.com/svn/django/trunk@3548 bcc190cf-cafb-0310-a4f2-bffc1f526a37
  • Loading branch information...
commit a6a402a7db45ea7d2bb8521b989de573c4f72fee 1 parent cba451c
Malcolm Tredinnick malcolmt authored
Showing with 8 additions and 5 deletions.
  1. +6 −5 django/db/models/base.py
  2. +2 −0  tests/modeltests/empty/models.py
11 django/db/models/base.py
View
@@ -176,11 +176,12 @@ def save(self):
# If it does already exist, do an UPDATE.
if cursor.fetchone():
db_values = [f.get_db_prep_save(f.pre_save(self, False)) for f in non_pks]
- cursor.execute("UPDATE %s SET %s WHERE %s=%%s" % \
- (backend.quote_name(self._meta.db_table),
- ','.join(['%s=%%s' % backend.quote_name(f.column) for f in non_pks]),
- backend.quote_name(self._meta.pk.column)),
- db_values + [pk_val])
+ if db_values:
+ cursor.execute("UPDATE %s SET %s WHERE %s=%%s" % \
+ (backend.quote_name(self._meta.db_table),
+ ','.join(['%s=%%s' % backend.quote_name(f.column) for f in non_pks]),
+ backend.quote_name(self._meta.pk.column)),
+ db_values + [pk_val])
else:
record_exists = False
if not pk_set or not record_exists:
2  tests/modeltests/empty/models.py
View
@@ -20,5 +20,7 @@ class Empty(models.Model):
2
>>> m.id is not None
True
+>>> existing = Empty(m.id)
+>>> existing.save()
"""
Please sign in to comment.
Something went wrong with that request. Please try again.