Permalink
Browse files

Improved assertion error messages in validators tests

  • Loading branch information...
1 parent 9a2bcee commit a8f888feb464afd7cfbe024242fa2a405a2d5f90 @claudep claudep committed Oct 9, 2012
Showing with 14 additions and 2 deletions.
  1. +14 −2 tests/modeltests/validators/tests.py
View
16 tests/modeltests/validators/tests.py
@@ -162,11 +162,23 @@ def create_simple_test_method(validator, expected, value, num):
if expected is not None and issubclass(expected, Exception):
test_mask = 'test_%s_raises_error_%d'
def test_func(self):
- self.assertRaises(expected, validator, value)
+ # assertRaises not used, so as to be able to produce an error message
+ # containing the tested value
+ try:
+ validator(value)
+ except expected:
+ pass
+ else:
+ self.fail("%s not raised when validating '%s'" % (
+ expected.__name__, value))
else:
test_mask = 'test_%s_%d'
def test_func(self):
- self.assertEqual(expected, validator(value))
+ try:
+ self.assertEqual(expected, validator(value))
+ except ValidationError as e:
+ self.fail("Validation of '%s' failed. Error message was: %s" % (
+ value, str(e)))
if isinstance(validator, types.FunctionType):
val_name = validator.__name__
else:

0 comments on commit a8f888f

Please sign in to comment.