Skip to content

HTTPS clone URL

Subversion checkout URL

You can clone with
or
.
Download ZIP
Browse files

Fixed #21089 -- Allow TransactionTestcase subclasses to define an emp…

…ty list of fixtures.

Thanks to lgs for the report and initial patch.
  • Loading branch information...
commit abb10db06fb2ecb3e897462ec72417d10b39b8a4 1 parent 170f721
@bmispelon bmispelon authored
Showing with 16 additions and 2 deletions.
  1. +5 −2 django/test/testcases.py
  2. +11 −0 tests/fixtures/tests.py
View
7 django/test/testcases.py
@@ -699,6 +699,9 @@ class TransactionTestCase(SimpleTestCase):
# Subclasses can enable only a subset of apps for faster tests
available_apps = None
+ # Subclasses can define fixtures which will be automatically installed.
+ fixtures = None
+
def _pre_setup(self):
"""Performs any pre-test setup. This includes:
@@ -746,7 +749,7 @@ def _fixture_setup(self):
if self.reset_sequences:
self._reset_sequences(db_name)
- if hasattr(self, 'fixtures'):
+ if self.fixtures:
# We have to use this slightly awkward syntax due to the fact
# that we're using *args and **kwargs together.
call_command('loaddata', *self.fixtures,
@@ -838,7 +841,7 @@ def _fixture_setup(self):
disable_transaction_methods()
for db_name in self._databases_names(include_mirrors=False):
- if hasattr(self, 'fixtures'):
+ if self.fixtures:
try:
call_command('loaddata', *self.fixtures,
**{
View
11 tests/fixtures/tests.py
@@ -24,6 +24,17 @@ def testClassFixtures(self):
])
+class SubclassTestCaseFixtureLoadingTests(TestCaseFixtureLoadingTests):
+ """
+ Make sure that subclasses can remove fixtures from parent class (#21089).
+ """
+ fixtures = []
+
+ def testClassFixtures(self):
+ "Check that there were no fixture objects installed"
+ self.assertEqual(Article.objects.count(), 0)
+
+
class DumpDataAssertMixin(object):
def _dumpdata_assert(self, args, output, format='json', natural_keys=False,
Please sign in to comment.
Something went wrong with that request. Please try again.