Skip to content

HTTPS clone URL

Subversion checkout URL

You can clone with HTTPS or Subversion.

Download ZIP
Browse files

Use Python's changed comparisons, which makes this a bit more readable.

git-svn-id: http://code.djangoproject.com/svn/django/trunk@17526 bcc190cf-cafb-0310-a4f2-bffc1f526a37
  • Loading branch information...
commit b9b3e9f0efe3fe9d5d976533ff2f13359825f5da 1 parent 6072e10
@alex alex authored
Showing with 2 additions and 2 deletions.
  1. +1 −1  django/utils/http.py
  2. +1 −1  tests/regressiontests/utils/http.py
View
2  django/utils/http.py
@@ -171,7 +171,7 @@ def int_to_base36(i):
"""
digits = "0123456789abcdefghijklmnopqrstuvwxyz"
factor = 0
- if (i < 0) or (i > sys.maxint):
+ if not 0 <= i <= sys.maxint:
raise ValueError("Base36 conversion input too large or incorrect type.")
# Find starting factor
while True:
View
2  tests/regressiontests/utils/http.py
@@ -119,6 +119,6 @@ def test_base36(self):
self.assertRaises(TypeError, http.int_to_base36, 3.141)
# more explicit output testing
- for n, b36 in [(0,'0'), (1,'1'), (42,'16'), (818469960,'django')]:
+ for n, b36 in [(0, '0'), (1, '1'), (42, '16'), (818469960, 'django')]:
self.assertEqual(http.int_to_base36(n), b36)
self.assertEqual(http.base36_to_int(b36), n)
Please sign in to comment.
Something went wrong with that request. Please try again.