Skip to content

HTTPS clone URL

Subversion checkout URL

You can clone with HTTPS or Subversion.

Download ZIP
Browse files

Fixed #14941 -- Stop raising ValidationError in form fields that use …

…the URLValidator and get a IDN domain passed. Thanks, Claude Paroz.

git-svn-id: http://code.djangoproject.com/svn/django/trunk@15504 bcc190cf-cafb-0310-a4f2-bffc1f526a37
  • Loading branch information...
commit ba1876cef22e46fe4e80ce32547ec9870991b63b 1 parent bc5c253
Jannis Leidel jezdez authored
1  django/core/validators.py
View
@@ -84,6 +84,7 @@ def __call__(self, value):
"Connection": "close",
"User-Agent": self.user_agent,
}
+ url = url.encode('utf-8')
broken_error = ValidationError(
_(u'This URL appears to be a broken link.'), code='invalid_link')
try:
2  tests/regressiontests/forms/tests/fields.py
View
@@ -571,6 +571,8 @@ def test_urlfield_3(self):
f.clean('http://google.com/we-love-microsoft.html') # good domain, bad page
except ValidationError, e:
self.assertEqual("[u'This URL appears to be a broken link.']", str(e))
+ # UTF-8 char in path
+ self.assertEqual(u'http://de.wikipedia.org/wiki/T\xfcr', f.clean(u'http://de.wikipedia.org/wiki/T\xfcr'))
def test_urlfield_4(self):
f = URLField(verify_exists=True, required=False)
Please sign in to comment.
Something went wrong with that request. Please try again.