Skip to content
Browse files

Added section info on top-level use of django.conf.settings to 'contr…

…ibuting' documentation

git-svn-id: bcc190cf-cafb-0310-a4f2-bffc1f526a37
  • Loading branch information...
1 parent 81dd5c2 commit bb428f3e86953d09df050b2614639f5c8a68840d @spookylukey spookylukey committed
Showing with 41 additions and 0 deletions.
  1. +41 −0 docs/internals/contributing.txt
41 docs/internals/contributing.txt
@@ -426,6 +426,47 @@ translated, here's what to do:
.. _Django i18n mailing list:
+Django conventions
+Various Django-specific code issues are detailed in this section.
+Use of ``django.conf.settings``
+Modules should not in general use settings stored in ``django.conf.settings`` at
+the top level (i.e. evaluated when the module is imported). The explanation for
+this is as follows:
+Manual configuration of settings (i.e. not relying on the
+``DJANGO_SETTINGS_MODULE`` environment variable) is allowed and possible as
+ from django.conf import settings
+ settings.configure({}, SOME_SETTING='foo')
+However, if any setting is accessed before the ``settings.configure`` line, this
+will not work. (Internally, ``setttings`` is a ``LazyObject`` which configures
+itself automatically when the settings are accessed if it has not already been
+So, if there is a module containg some code as follows::
+ from django.conf import settings
+ from django.core.urlresolvers import get_callable
+ default_foo_view = get_callable(settings.FOO_VIEW)
+...then importing this module will cause the settings object to be configured.
+That means that the ability for third parties to import the module at the top
+level is incompatible with the ability to configure the settings object
+manually, or makes it very difficult in some circumstances.
+Instead of the above code, a level of laziness or indirection must be used, such
+as :class:`django.utils.functional.LazyObject`, :func:`django.utils.functional.lazy` or
Coding style

0 comments on commit bb428f3

Please sign in to comment.
Something went wrong with that request. Please try again.