Skip to content


Subversion checkout URL

You can clone with
Download ZIP
Browse files

Fix test from r16678 and r16681 properly for Oracle.

Fixes #16694, with thanks to aagustin for the Oracle testing and

git-svn-id: bcc190cf-cafb-0310-a4f2-bffc1f526a37
  • Loading branch information...
1 parent b0764e8 commit bb99fe46b7915ef131ba54e8348c9a1d52bd6ddd @malcolmt malcolmt committed
Showing with 5 additions and 2 deletions.
  1. +5 −2 tests/modeltests/invalid_models/invalid_models/
7 tests/modeltests/invalid_models/invalid_models/
@@ -5,7 +5,7 @@
This example exists purely to point out errors in models.
-from django.db import models
+from django.db import connection, models
class FieldErrors(models.Model):
charfield = models.CharField()
@@ -342,5 +342,8 @@ class PrimaryKeyNull(models.Model):
invalid_models.nonexistingorderingwithsingleunderscore: "ordering" refers to "does_not_exist", a field that doesn't exist.
invalid_models.invalidsetnull: 'fk' specifies on_delete=SET_NULL, but cannot be null.
invalid_models.invalidsetdefault: 'fk' specifies on_delete=SET_DEFAULT, but has no default value.
-invalid_models.primarykeynull: "my_pk_field": Primary key fields cannot have null=True.
+if not connection.features.interprets_empty_strings_as_nulls:
+ model_errors += """invalid_models.primarykeynull: "my_pk_field": Primary key fields cannot have null=True.

0 comments on commit bb99fe4

Please sign in to comment.
Something went wrong with that request. Please try again.