Skip to content

HTTPS clone URL

Subversion checkout URL

You can clone with HTTPS or Subversion.

Download ZIP
Browse files

Fixed #2300 -- Added required "value" attribute to CheckboxSelectMult…

…ipleField

form field. Converted the submitted data for the same field back into something
we can work with. Thanks, lerouxb@gmail.com.


git-svn-id: http://code.djangoproject.com/svn/django/trunk@3850 bcc190cf-cafb-0310-a4f2-bffc1f526a37
  • Loading branch information...
commit be053df69341e98ef46c6ec3429d8f0812aab9f0 1 parent 11416e4
Malcolm Tredinnick malcolmt authored
Showing with 2 additions and 1 deletion.
  1. +2 −1  django/forms/__init__.py
3  django/forms/__init__.py
View
@@ -54,6 +54,7 @@ def prepare(self, new_data):
def get_validation_errors(self, new_data):
"Returns dictionary mapping field_names to error-message lists"
errors = {}
+ self.prepare(new_data)
for field in self.fields:
errors.update(field.get_validation_errors(new_data))
val_name = 'validate_%s' % field.field_name
@@ -638,7 +639,7 @@ def render(self, data):
if str(value) in str_data_list:
checked_html = ' checked="checked"'
field_name = '%s%s' % (self.field_name, value)
- output.append('<li><input type="checkbox" id="%s" class="v%s" name="%s"%s /> <label for="%s">%s</label></li>' % \
+ output.append('<li><input type="checkbox" id="%s" class="v%s" name="%s"%s value="on" /> <label for="%s">%s</label></li>' % \
(self.get_id() + escape(value), self.__class__.__name__, field_name, checked_html,
self.get_id() + escape(value), choice))
output.append('</ul>')
Please sign in to comment.
Something went wrong with that request. Please try again.