Permalink
Browse files

Fixed #18779 -- URLValidator can't validate url with ipv6.

Validation is reasonably 'soft', as for the ipv4. False positives don't
matter too much here.
  • Loading branch information...
1 parent 16ab519 commit bfa9fc69bf0afae907af0ba3ef2cab8e10a4fa61 @mjtamlyn mjtamlyn committed Aug 18, 2012
Showing with 14 additions and 1 deletion.
  1. +2 −1 django/core/validators.py
  2. +12 −0 tests/regressiontests/forms/tests/fields.py
@@ -44,7 +44,8 @@ class URLValidator(RegexValidator):
r'^(?:http|ftp)s?://' # http:// or https://
r'(?:(?:[A-Z0-9](?:[A-Z0-9-]{0,61}[A-Z0-9])?\.)+(?:[A-Z]{2,6}\.?|[A-Z0-9-]{2,}\.?)|' #domain...
r'localhost|' #localhost...
- r'\d{1,3}\.\d{1,3}\.\d{1,3}\.\d{1,3})' # ...or ip
+ r'\d{1,3}\.\d{1,3}\.\d{1,3}\.\d{1,3}|' # ...or ipv4
+ r'\[?[A-F0-9]*:[A-F0-9:]+\]?)' # ...or ipv6
r'(?::\d+)?' # optional port
r'(?:/?|[/?]\S+)$', re.IGNORECASE)
@@ -668,6 +668,18 @@ def test_urlfield_9(self):
# Valid IDN
self.assertEqual(url, f.clean(url))
+ def test_urlfield_10(self):
+ """Test URLField correctly validates IPv6 (#18779)."""
+ f = URLField()
+ urls = (
+ 'http://::/',
+ 'http://6:21b4:92/',
+ 'http://[12:34:3a53]/',
+ 'http://[a34:9238::]:8080/',
+ )
+ for url in urls:
+ self.assertEqual(url, f.clean(url))
+
def test_urlfield_not_string(self):
f = URLField(required=False)
self.assertRaisesMessage(ValidationError, "'Enter a valid URL.'", f.clean, 23)

0 comments on commit bfa9fc6

Please sign in to comment.