Skip to content
This repository

HTTPS clone URL

Subversion checkout URL

You can clone with HTTPS or Subversion.

Download ZIP
Browse code

Fixed sending mail on 404s to fail silently.

A failure in the e-mail system should not turn a 404 into a 500.

git-svn-id: http://code.djangoproject.com/svn/django/trunk@15145 bcc190cf-cafb-0310-a4f2-bffc1f526a37
  • Loading branch information...
commit c0dd2babb153f1c82bd38f211a32602620dce177 1 parent 30fbe92
Luke Plant authored January 04, 2011

Showing 1 changed file with 2 additions and 1 deletion. Show diff stats Hide diff stats

  1. 3  django/middleware/common.py
3  django/middleware/common.py
@@ -104,7 +104,8 @@ def process_response(self, request, response):
104 104
                     ip = request.META.get('REMOTE_ADDR', '<none>')
105 105
                     mail_managers("Broken %slink on %s" % ((is_internal and 'INTERNAL ' or ''), domain),
106 106
                         "Referrer: %s\nRequested URL: %s\nUser agent: %s\nIP address: %s\n" \
107  
-                                  % (referer, request.get_full_path(), ua, ip))
  107
+                                  % (referer, request.get_full_path(), ua, ip),
  108
+                                  fail_silently=True)
108 109
                 return response
109 110
 
110 111
         # Use ETags, if requested.

0 notes on commit c0dd2ba

Please sign in to comment.
Something went wrong with that request. Please try again.