Skip to content


Subversion checkout URL

You can clone with
Download ZIP
Browse files

Fixed #3312 -- CheckboxSelectMultiple no longer uses duplicate ID att…

…ributes for each checkbox

git-svn-id: bcc190cf-cafb-0310-a4f2-bffc1f526a37
  • Loading branch information...
1 parent 982a944 commit c0e01416b68e482172ef23cc507f163b873c192a @adrianholovaty adrianholovaty committed
Showing with 17 additions and 2 deletions.
  1. +7 −2 django/newforms/
  2. +10 −0 tests/regressiontests/forms/
9 django/newforms/
@@ -258,11 +258,16 @@ def id_for_label(self, id_):
class CheckboxSelectMultiple(SelectMultiple):
def render(self, name, value, attrs=None, choices=()):
if value is None: value = []
+ has_id = attrs and attrs.has_key('id')
final_attrs = self.build_attrs(attrs, name=name)
output = [u'<ul>']
str_values = set([smart_unicode(v) for v in value]) # Normalize to strings.
- cb = CheckboxInput(final_attrs, check_test=lambda value: value in str_values)
- for option_value, option_label in chain(self.choices, choices):
+ for i, (option_value, option_label) in enumerate(chain(self.choices, choices)):
+ # If an ID attribute was given, add a numeric index as a suffix,
+ # so that the checkboxes don't all have the same ID attribute.
+ if has_id:
+ final_attrs = dict(final_attrs, id='%s_%s' % (attrs['id'], i))
+ cb = CheckboxInput(final_attrs, check_test=lambda value: value in str_values)
option_value = smart_unicode(option_value)
rendered_cb = cb.render(name, option_value)
output.append(u'<li><label>%s %s</label></li>' % (rendered_cb, escape(smart_unicode(option_label))))
10 tests/regressiontests/forms/
@@ -2149,6 +2149,16 @@
<li><label><input checked="checked" type="checkbox" name="composers" value="P" /> Paul McCartney</label></li>
+Regarding auto_id, CheckboxSelectMultiple is a special case. Each checkbox
+gets a distinct ID, formed by appending an underscore plus the checkbox's
+zero-based index.
+>>> f = SongForm(auto_id='%s_id')
+>>> print f['composers']
+<li><label><input type="checkbox" name="composers" value="J" id="composers_id_0" /> John Lennon</label></li>
+<li><label><input type="checkbox" name="composers" value="P" id="composers_id_1" /> Paul McCartney</label></li>
Data for a MultipleChoiceField should be a list. QueryDict and MultiValueDict
conveniently work with this.
>>> data = {'name': 'Yesterday', 'composers': ['J', 'P']}

0 comments on commit c0e0141

Please sign in to comment.
Something went wrong with that request. Please try again.