Skip to content

HTTPS clone URL

Subversion checkout URL

You can clone with HTTPS or Subversion.

Download ZIP
Browse files

Fixed get_absolute_url() for comments. Previously, it relied on "view…

… on site"

for admin being reversible or required people to set up their own version. Now
we ship a default pattern in the comments URLs in a way that is unlikely to
clash with anything else.


git-svn-id: http://code.djangoproject.com/svn/django/trunk@8614 bcc190cf-cafb-0310-a4f2-bffc1f526a37
  • Loading branch information...
commit c305471610e8da8589b8b7b20a1a2b6c0dcbc3d9 1 parent 157dbe2
@malcolmt malcolmt authored
View
5 django/contrib/comments/models.py
@@ -30,11 +30,10 @@ class Meta:
def get_content_object_url(self):
"""
- Get a URL suitable for redirecting to the content object. Uses the
- ``django.views.defaults.shortcut`` view, which thus must be installed.
+ Get a URL suitable for redirecting to the content object.
"""
return urlresolvers.reverse(
- "django.views.defaults.shortcut",
+ "comments-url-redirect",
args=(self.content_type_id, self.object_pk)
)
View
4 django/contrib/comments/urls.py
@@ -13,3 +13,7 @@
url(r'^approved/$', 'moderation.approve_done', name='comments-approve-done'),
)
+urlpatterns += patterns('',
+ url(r'^cr/(\d+)/(\w+)/$', 'django.views.defaults.shortcut', name='comments-url-redirect'),
+)
+
Please sign in to comment.
Something went wrong with that request. Please try again.