Skip to content

HTTPS clone URL

Subversion checkout URL

You can clone with
or
.
Download ZIP
Browse files

Fixed #3810 -- In newforms, copy attribute dictionaries before modify…

…ing them

in place.


git-svn-id: http://code.djangoproject.com/svn/django/trunk@4894 bcc190cf-cafb-0310-a4f2-bffc1f526a37
  • Loading branch information...
commit c60587b5a7692807c2d0f1970d45e2bde724233d 1 parent 4e31a17
@malcolmt malcolmt authored
View
5 django/newforms/widgets.py
@@ -24,7 +24,10 @@ class Widget(object):
is_hidden = False # Determines whether this corresponds to an <input type="hidden">.
def __init__(self, attrs=None):
- self.attrs = attrs or {}
+ if attrs is not None:
+ self.attrs = attrs.copy()
+ else:
+ self.attrs = {}
def render(self, name, value, attrs=None):
"""
View
13 tests/regressiontests/forms/regressions.py
@@ -0,0 +1,13 @@
+# -*- coding: utf-8 -*-
+# Tests to prevent against recurrences of earlier bugs.
+
+regression_tests = r"""
+It should be possible to re-use attribute dictionaries (#3810)
+>>> from django.newforms import *
+>>> extra_attrs = {'class': 'special'}
+>>> class TestForm(Form):
+... f1 = CharField(max_length=10, widget=TextInput(attrs=extra_attrs))
+... f2 = CharField(widget=TextInput(attrs=extra_attrs))
+>>> TestForm(auto_id=False).as_p()
+u'<p>F1: <input type="text" class="special" name="f1" maxlength="10" /></p>\n<p>F2: <input type="text" class="special" name="f2" /></p>'
+"""
View
2  tests/regressiontests/forms/tests.py
@@ -1,5 +1,6 @@
# -*- coding: utf-8 -*-
from localflavor import localflavor_tests
+from regressions import regression_tests
form_tests = r"""
>>> from django.newforms import *
@@ -3297,6 +3298,7 @@
__test__ = {
'form_tests': form_tests,
'localflavor': localflavor_tests,
+ 'regressions': regression_tests,
}
if __name__ == "__main__":
Please sign in to comment.
Something went wrong with that request. Please try again.