Permalink
Browse files

Fixed a couple unclosed file warnings in tests

  • Loading branch information...
1 parent 3db66b1 commit cb98ffe8f45d77a7e892fbb80b47de999062dc74 @timgraham timgraham committed Sep 3, 2013
Showing with 6 additions and 4 deletions.
  1. +4 −3 tests/file_storage/tests.py
  2. +2 −1 tests/staticfiles_tests/tests.py
View
7 tests/file_storage/tests.py
@@ -567,9 +567,10 @@ def test_multiple_calls(self):
from django.core.files.images import ImageFile
img_path = os.path.join(os.path.dirname(upath(__file__)), "test.png")
- image = ImageFile(open(img_path, 'rb'))
- image_pil = Image.open(img_path)
- size_1, size_2 = get_image_dimensions(image), get_image_dimensions(image)
+ with open(img_path, 'rb') as file:
+ image = ImageFile(file)
+ image_pil = Image.open(img_path)
+ size_1, size_2 = get_image_dimensions(image), get_image_dimensions(image)
self.assertEqual(image_pil.size, size_1)
self.assertEqual(size_1, size_2)
View
3 tests/staticfiles_tests/tests.py
@@ -783,10 +783,11 @@ def setUp(self):
os.mkdir(self.search_path)
module_path = os.path.join(self.search_path, 'foo_module')
os.mkdir(module_path)
- open(os.path.join(module_path, '__init__.py'), 'w')
+ self.init_file = open(os.path.join(module_path, '__init__.py'), 'w')
sys.path.append(os.path.abspath(self.search_path))
def tearDown(self):
+ self.init_file.close()
sys.path.remove(os.path.abspath(self.search_path))
shutil.rmtree(self.search_path)

0 comments on commit cb98ffe

Please sign in to comment.