Skip to content

HTTPS clone URL

Subversion checkout URL

You can clone with HTTPS or Subversion.

Download ZIP
Browse files

Removed non-necessary code in Compiler._setup_joins()

  • Loading branch information...
commit ccbba98131ace3beb43790c65e8f4eee94e9631c 1 parent ba6c9fa
Anssi Kääriäinen akaariai authored
Showing with 1 addition and 7 deletions.
  1. +1 −7 django/db/models/sql/compiler.py
8 django/db/models/sql/compiler.py
View
@@ -452,8 +452,7 @@ def find_ordering_name(self, name, opts, alias=None, default_order='ASC',
def _setup_joins(self, pieces, opts, alias):
"""
- A helper method for get_ordering and get_distinct. This method will
- call query.setup_joins and handle refcounts.
+ A helper method for get_ordering and get_distinct.
Note that get_ordering and get_distinct must produce same target
columns on same input, as the prefixes of get_ordering and get_distinct
@@ -464,11 +463,6 @@ def _setup_joins(self, pieces, opts, alias):
field, targets, opts, joins, path = self.query.setup_joins(
pieces, opts, alias)
alias = joins[-1]
- if not field.rel:
- # To avoid inadvertent trimming of a necessary alias, use the
- # refcount to show that we are referencing a non-relation field on
- # the model.
- self.query.ref_alias(alias)
return field, targets, alias, joins, path, opts
def get_from_clause(self):
Please sign in to comment.
Something went wrong with that request. Please try again.