Skip to content

HTTPS clone URL

Subversion checkout URL

You can clone with HTTPS or Subversion.

Download ZIP
Browse files

Fixed test failure on Oracle: model_fields.tests.test_float_validates…

…_object

Failing test introduced in fix for refs #22210.
  • Loading branch information...
commit d181384e5f01e9d23fd9872b2cb532e0d70249b6 1 parent aaad3e2
@shaib shaib authored
Showing with 15 additions and 3 deletions.
  1. +15 −3 tests/model_fields/tests.py
View
18 tests/model_fields/tests.py
@@ -8,7 +8,7 @@
from django import test
from django import forms
from django.core.exceptions import ValidationError
-from django.db import connection, models, IntegrityError
+from django.db import connection, transaction, models, IntegrityError
from django.db.models.fields import (
AutoField, BigIntegerField, BinaryField, BooleanField, CharField,
CommaSeparatedIntegerField, DateField, DateTimeField, DecimalField,
@@ -80,10 +80,22 @@ def test_field_verbose_name(self):
def test_float_validates_object(self):
instance = FloatModel(size=2.5)
+ # Try setting float field to unsaved object
+ instance.size = instance
+ with transaction.atomic():
+ with self.assertRaises(TypeError):
+ instance.save()
+ # Set value to valid and save
+ instance.size = 2.5
instance.save()
self.assertTrue(instance.id)
-
- obj = FloatModel.objects.get(pk=1)
+ # Set field to object on saved instance
+ instance.size = instance
+ with transaction.atomic():
+ with self.assertRaises(TypeError):
+ instance.save()
+ # Try setting field to object on retrieved object
+ obj = FloatModel.objects.get(pk=instance.id)
obj.size = obj
with self.assertRaises(TypeError):
obj.save()
Please sign in to comment.
Something went wrong with that request. Please try again.