Skip to content

HTTPS clone URL

Subversion checkout URL

You can clone with
or
.
Download ZIP
Browse files

Fixed #13815 -- Ensure that reverse exclude lookups on nullable forei…

…gn keys exclude null values. Thanks to bpeschier for the report and patch.

git-svn-id: http://code.djangoproject.com/svn/django/trunk@15458 bcc190cf-cafb-0310-a4f2-bffc1f526a37
  • Loading branch information...
commit d3b38d578f41240442cb043012b0035a20eebd67 1 parent 340eade
@freakboy3742 freakboy3742 authored
View
7 django/db/models/sql/query.py
@@ -1475,6 +1475,13 @@ def split_exclude(self, filter_expr, prefix, can_reuse):
query.bump_prefix()
query.clear_ordering(True)
query.set_start(prefix)
+ # Adding extra check to make sure the selected field will not be null
+ # since we are adding a IN <subquery> clause. This prevents the
+ # database from tripping over IN (...,NULL,...) selects and returning
+ # nothing
+ alias, col = query.select[0]
+ query.where.add((Constraint(alias, col, None), 'isnull', False), AND)
+
self.add_filter(('%s__in' % prefix, query), negate=True, trim=True,
can_reuse=can_reuse)
View
12 tests/regressiontests/null_queries/tests.py
@@ -67,3 +67,15 @@ def test_reverse_relations(self):
['<Inner: Inner object>']
)
+ # Ticket #13815: check if <reverse>_isnull=False does not produce
+ # faulty empty lists
+ objB = OuterB.objects.create(data="reverse")
+ self.assertQuerysetEqual(
+ OuterB.objects.filter(inner__isnull=False),
+ []
+ )
+ Inner.objects.create(first=obj)
+ self.assertQuerysetEqual(
+ OuterB.objects.exclude(inner__isnull=False),
+ ['<OuterB: OuterB object>']
+ )
Please sign in to comment.
Something went wrong with that request. Please try again.