Skip to content
This repository

HTTPS clone URL

Subversion checkout URL

You can clone with HTTPS or Subversion.

Download ZIP
Browse code

Fixed #11322 -- Clarified docs regarding middleware processing. Thank…

…s the Michael Malone for the patch.

git-svn-id: http://code.djangoproject.com/svn/django/trunk@11048 bcc190cf-cafb-0310-a4f2-bffc1f526a37
  • Loading branch information...
commit d71097111ae1a5f54c8413be4b9af0c97b8904ef 1 parent 4086167
Russell Keith-Magee authored June 18, 2009

Showing 1 changed file with 9 additions and 6 deletions. Show diff stats Hide diff stats

  1. 15  docs/topics/http/middleware.txt
15  docs/topics/http/middleware.txt
@@ -107,15 +107,18 @@ middleware is always called on every response.
107 107
 ``request`` is an :class:`~django.http.HttpRequest` object. ``response`` is the
108 108
 :class:`~django.http. HttpResponse` object returned by a Django view.
109 109
 
110  
-``process_response()`` should return an :class:`~django.http. HttpResponse`
  110
+``process_response()`` must return an :class:`~django.http. HttpResponse`
111 111
 object. It could alter the given ``response``, or it could create and return a
112 112
 brand-new :class:`~django.http. HttpResponse`.
113 113
 
114  
-Remember that your middleware will not be called if another middleware object
115  
-returns a response before you. But unlike ``process_request()`` and
116  
-``process_view()``, during the response phase the classes are applied in reverse
117  
-order, from the bottom up. This means classes defined at the end of
118  
-:setting:`MIDDLEWARE_CLASSES` will be run first.
  114
+Unlike the ``process_request()`` and ``process_view()`` methods, the
  115
+``process_response()`` method is always called, even if the ``process_request()``
  116
+and ``process_view()`` methods of the same middleware class were skipped because
  117
+an earlier middleware method returned an :class:`~django.http. HttpResponse`
  118
+(this means that your ``process_response()`` method cannot rely on setup done in
  119
+``process_request()``, for example). In addition, during the response phase the
  120
+classes are applied in reverse order, from the bottom up. This means classes
  121
+defined at the end of :setting:`MIDDLEWARE_CLASSES` will be run first.
119 122
 
120 123
 .. _exception-middleware:
121 124
 

0 notes on commit d710971

Please sign in to comment.
Something went wrong with that request. Please try again.