Skip to content
Browse files

Removed warning check in test_load_overlong_key

Some backends issue a warning here, others not. This is not the primary
goal of the test, so the assertion about the warning has been removed.
Thanks Carl Meyer for noticing the issue and suggesting the fix.
  • Loading branch information...
1 parent 3bdb65d commit d7853c55ed027cdffcda88205b9d5c16861a5bcb @claudep claudep committed
Showing with 4 additions and 6 deletions.
  1. +4 −6 django/contrib/sessions/tests.py
View
10 django/contrib/sessions/tests.py
@@ -302,11 +302,10 @@ def test_exists_searches_cache_first(self):
self.assertTrue(self.session.exists(self.session.session_key))
def test_load_overlong_key(self):
- with warnings.catch_warnings(record=True) as w:
- warnings.simplefilter("always")
+ # Some backends might issue a warning
+ with warnings.catch_warnings():
self.session._session_key = (string.ascii_letters + string.digits) * 20
self.assertEqual(self.session.load(), {})
- self.assertEqual(len(w), 1)
@override_settings(USE_TZ=True)
@@ -352,11 +351,10 @@ class CacheSessionTests(SessionTestsMixin, unittest.TestCase):
backend = CacheSession
def test_load_overlong_key(self):
- with warnings.catch_warnings(record=True) as w:
- warnings.simplefilter("always")
+ # Some backends might issue a warning
+ with warnings.catch_warnings():
self.session._session_key = (string.ascii_letters + string.digits) * 20
self.assertEqual(self.session.load(), {})
- self.assertEqual(len(w), 1)
class SessionMiddlewareTests(unittest.TestCase):

0 comments on commit d7853c5

Please sign in to comment.
Something went wrong with that request. Please try again.