Skip to content

HTTPS clone URL

Subversion checkout URL

You can clone with HTTPS or Subversion.

Download ZIP
Browse files

Cleaned up some lingering signals in the test suite that were causing…

… spurious failures with Pypy and Postgres.
  • Loading branch information...
commit db09a2de6e1bc7121d301dad9610efcda9c7a925 1 parent 868e0f3
Julien Phalip jphalip authored
6 tests/modeltests/update_only_fields/tests.py
View
@@ -207,6 +207,9 @@ def post_save_receiver(**kwargs):
self.assertEqual(len(post_save_data[0]), 1)
self.assertTrue('name' in post_save_data[0])
+ pre_save.disconnect(pre_save_receiver)
+ post_save.disconnect(post_save_receiver)
+
def test_update_fields_incorrect_params(self):
s = Person.objects.create(name='Sara', gender='F')
@@ -233,6 +236,9 @@ def post_save_receiver(**kwargs):
self.assertEqual(len(pre_save_data), 0)
self.assertEqual(len(post_save_data), 0)
+ pre_save.disconnect(pre_save_receiver)
+ post_save.disconnect(post_save_receiver)
+
def test_num_queries_inheritance(self):
s = Employee.objects.create(name='Sara', gender='F')
s.employee_num = 1
6 tests/regressiontests/comment_tests/tests/moderation_view_tests.py
View
@@ -93,6 +93,8 @@ def receive(sender, **kwargs):
self.testFlagPost()
self.assertEqual(received_signals, [signals.comment_was_flagged])
+ signals.comment_was_flagged.disconnect(receive)
+
def makeModerator(username):
u = User.objects.get(username=username)
ct = ContentType.objects.get_for_model(Comment)
@@ -164,6 +166,8 @@ def receive(sender, **kwargs):
self.testDeletePost()
self.assertEqual(received_signals, [signals.comment_was_flagged])
+ signals.comment_was_flagged.disconnect(receive)
+
def testDeletedView(self):
comments = self.createSomeComments()
pk = comments[0].pk
@@ -239,6 +243,8 @@ def receive(sender, **kwargs):
self.testApprovePost()
self.assertEqual(received_signals, [signals.comment_was_flagged])
+ signals.comment_was_flagged.disconnect(receive)
+
def testApprovedView(self):
comments = self.createSomeComments()
pk = comments[0].pk
5 tests/regressiontests/multiple_database/tests.py
View
@@ -1761,6 +1761,11 @@ def test_database_arg_save_and_delete(self):
self.assertEqual(pre_delete_receiver._database, "other")
self.assertEqual(post_delete_receiver._database, "other")
+ signals.pre_save.disconnect(sender=Person, receiver=pre_save_receiver)
+ signals.post_save.disconnect(sender=Person, receiver=post_save_receiver)
+ signals.pre_delete.disconnect(sender=Person, receiver=pre_delete_receiver)
+ signals.post_delete.disconnect(sender=Person, receiver=post_delete_receiver)
+
def test_database_arg_m2m(self):
"""
Test that the m2m_changed signal has a correct database arg (#13552)
Please sign in to comment.
Something went wrong with that request. Please try again.