Skip to content


Subversion checkout URL

You can clone with HTTPS or Subversion.

Download ZIP
Browse files

Backwards-incompatible change: renamed HttpResponse.headers to HttpRe…

…sponse._headers to deliberately break anyone accessing headers directly instead of through the case-insensitive proxies on HttpResponse itself. See BackwardsIncompatibleChanges for more details.

git-svn-id: bcc190cf-cafb-0310-a4f2-bffc1f526a37
  • Loading branch information...
commit dd799591fc9f6ab0d988e0dc82f47276bdab6b2a 1 parent 8cf9a6d
@jacobian jacobian authored
Showing with 6 additions and 6 deletions.
  1. +6 −6 django/http/
12 django/http/
@@ -246,7 +246,7 @@ def __init__(self, content='', mimetype=None, status=None,
self._container = [content]
self._is_string = True
- self.headers = {'content-type': content_type}
+ self._headers = {'content-type': content_type}
self.cookies = SimpleCookie()
if status:
self.status_code = status
@@ -254,24 +254,24 @@ def __init__(self, content='', mimetype=None, status=None,
def __str__(self):
"Full HTTP message, including headers"
return '\n'.join(['%s: %s' % (key, value)
- for key, value in self.headers.items()]) \
+ for key, value in self._headers.items()]) \
+ '\n\n' + self.content
def __setitem__(self, header, value):
- self.headers[header.lower()] = value
+ self._headers[header.lower()] = value
def __delitem__(self, header):
- del self.headers[header.lower()]
+ del self._headers[header.lower()]
except KeyError:
def __getitem__(self, header):
- return self.headers[header.lower()]
+ return self._headers[header.lower()]
def has_header(self, header):
"Case-insensitive check for a header"
- return self.headers.has_key(header.lower())
+ return self._headers.has_key(header.lower())
__contains__ = has_header
Please sign in to comment.
Something went wrong with that request. Please try again.