Permalink
Browse files

Fixed small bug in 'The view ____ didn't return an HttpResponse objec…

…t' message -- it assumed the view was a function, whereas it can be any callable object

git-svn-id: http://code.djangoproject.com/svn/django/trunk@4128 bcc190cf-cafb-0310-a4f2-bffc1f526a37
  • Loading branch information...
1 parent 9c44d8b commit e1d23323b631436eaae78bb5e4676d83c97d7a6c @adrianholovaty adrianholovaty committed Nov 28, 2006
Showing with 5 additions and 1 deletion.
  1. +5 −1 django/core/handlers/base.py
View
6 django/core/handlers/base.py
@@ -84,7 +84,11 @@ def get_response(self, request):
# Complain if the view returned None (a common error).
if response is None:
- raise ValueError, "The view %s.%s didn't return an HttpResponse object." % (callback.__module__, callback.func_name)
+ try:
+ view_name = callback.func_name # If it's a function
+ except AttributeError:
+ view_name = callback.__class__.__name__ + '.__call__' # If it's a class
+ raise ValueError, "The view %s.%s didn't return an HttpResponse object." % (callback.__module__, view_name)
return response
except http.Http404, e:

0 comments on commit e1d2332

Please sign in to comment.