Skip to content

Commit

Permalink
The tests now run correctly with the new psycopg2 backend. There's 4 …
Browse files Browse the repository at this point in the history
…failures, but they all have to do with the new way the psycopg2 handles datetimes and are probably a single fix.

git-svn-id: http://code.djangoproject.com/svn/django/trunk@2940 bcc190cf-cafb-0310-a4f2-bffc1f526a37
  • Loading branch information
jacobian committed May 18, 2006
1 parent 5a8ed6f commit e6ee971
Showing 1 changed file with 15 additions and 13 deletions.
28 changes: 15 additions & 13 deletions tests/runtests.py
Expand Up @@ -114,14 +114,11 @@ def run_tests(self):
global TEST_DATABASE_NAME
TEST_DATABASE_NAME = ":memory:"
else:
# Create the test database and connect to it. We need autocommit()
# because PostgreSQL doesn't allow CREATE DATABASE statements
# within transactions.
# Create the test database and connect to it. We need to autocommit
# if the database supports it because PostgreSQL doesn't allow
# CREATE/DROP DATABASE statements within transactions.
cursor = connection.cursor()
try:
connection.connection.autocommit(1)
except AttributeError:
pass
self._set_autocommit(connection)
self.output(1, "Creating test database")
try:
cursor.execute("CREATE DATABASE %s" % TEST_DATABASE_NAME)
Expand Down Expand Up @@ -224,12 +221,8 @@ def run_tests(self):
settings.DATABASE_NAME = old_database_name
cursor = connection.cursor()
self.output(1, "Deleting test database")
try:
connection.connection.autocommit(1)
except AttributeError:
pass
else:
time.sleep(1) # To avoid "database is being accessed by other users" errors.
self._set_autocommit(connection)
time.sleep(1) # To avoid "database is being accessed by other users" errors.
cursor.execute("DROP DATABASE %s" % TEST_DATABASE_NAME)

# Display output.
Expand All @@ -242,6 +235,15 @@ def run_tests(self):
print "%s error%s:" % (len(error_list), len(error_list) != 1 and 's' or '')
else:
print "All tests passed."

def _set_autocommit(self, connection):
"""
Make sure a connection is in autocommit mode.
"""
if hasattr(connection.connection, "autocommit"):
connection.connection.autocommit(True)
elif hasattr(connection.connection, "set_isolation_level"):
connection.connection.set_isolation_level(0)

if __name__ == "__main__":
from optparse import OptionParser
Expand Down

0 comments on commit e6ee971

Please sign in to comment.