Skip to content

HTTPS clone URL

Subversion checkout URL

You can clone with
or
.
Download ZIP
Browse files

Fixed #15624 -- Made sure aggregations are present in SELECT

  • Loading branch information...
commit e888a9b30dd9d62a930b9244d1b5531bb17544b4 1 parent e01b5a5
@fhahn fhahn authored akaariai committed
View
1  django/db/models/query.py
@@ -319,7 +319,6 @@ def aggregate(self, *args, **kwargs):
query.add_aggregate(aggregate_expr, self.model, alias,
is_summary=True)
aggregate_names.append(alias)
- query.append_aggregate_mask(aggregate_names)
return query.get_aggregation(using=self.db)
View
3  django/db/models/sql/query.py
@@ -321,6 +321,7 @@ def get_aggregation(self, using):
# information but retrieves only the first row. Aggregate
# over the subquery instead.
if self.group_by is not None:
+
from django.db.models.sql.subqueries import AggregateQuery
query = AggregateQuery(self.model)
@@ -996,6 +997,8 @@ def add_aggregate(self, aggregate, model, alias, is_summary):
field_name = field_list[0]
source = opts.get_field(field_name)
col = field_name
+ # We want to have the alias in SELECT clause even if mask is set.
+ self.append_aggregate_mask([alias])
# Add the aggregate to the query
aggregate.add_to_query(self, alias, col=col, source=source, is_summary=is_summary)
View
7 tests/aggregation_regress/tests.py
@@ -250,6 +250,13 @@ def test_aggrate_annotation(self):
'price__max': Decimal("82.80")
})
+ # Regression for #15624 - Missing SELECT columns when using values, annotate
+ # and aggregate in a single query
+ self.assertEqual(
+ Book.objects.annotate(c=Count('authors')).values('c').aggregate(Max('c')),
+ {'c__max': 3}
+ )
+
def test_field_error(self):
# Bad field requests in aggregates are caught and reported
self.assertRaises(
Please sign in to comment.
Something went wrong with that request. Please try again.