Skip to content

HTTPS clone URL

Subversion checkout URL

You can clone with HTTPS or Subversion.

Download ZIP
Browse files

Fixed #13370 -- Corrected the handling of pickling for lazy() proxy o…

…bjects. Thanks to Alex Gaynor for the report and patch.

git-svn-id: http://code.djangoproject.com/svn/django/trunk@13000 bcc190cf-cafb-0310-a4f2-bffc1f526a37
  • Loading branch information...
commit ebfe9383bfbc53cb6c29e1170d99f64feb9ad010 1 parent 56eb340
Russell Keith-Magee freakboy3742 authored
Showing with 17 additions and 9 deletions.
  1. +8 −7 django/utils/functional.py
  2. +9 −2 tests/regressiontests/i18n/tests.py
15 django/utils/functional.py
View
@@ -147,11 +147,6 @@ def lazy(func, *resultclasses):
the lazy evaluation code is triggered. Results are not memoized; the
function is evaluated on every access.
"""
- # When lazy() is called by the __reduce_ex__ machinery to reconstitute the
- # __proxy__ class it can't call with *args, so the first item will just be
- # a tuple.
- if len(resultclasses) == 1 and isinstance(resultclasses[0], tuple):
- resultclasses = resultclasses[0]
class __proxy__(Promise):
"""
@@ -168,8 +163,11 @@ def __init__(self, args, kw):
if self.__dispatch is None:
self.__prepare_class__()
- def __reduce_ex__(self, protocol):
- return (lazy, (self.__func, resultclasses), self.__dict__)
+ def __reduce__(self):
+ return (
+ _lazy_proxy_unpickle,
+ (self.__func, self.__args, self.__kw) + resultclasses
+ )
def __prepare_class__(cls):
cls.__dispatch = {}
@@ -249,6 +247,9 @@ def __wrapper__(*args, **kw):
return wraps(func)(__wrapper__)
+def _lazy_proxy_unpickle(func, args, kwargs, *resultclasses):
+ return lazy(func, *resultclasses)(*args, **kwargs)
+
def allow_lazy(func, *resultclasses):
"""
A decorator that allows a function to be called with one or more lazy
11 tests/regressiontests/i18n/tests.py
View
@@ -1,8 +1,9 @@
# -*- encoding: utf-8 -*-
+import datetime
+import decimal
import os
import sys
-import decimal
-import datetime
+import pickle
from django.template import Template, Context
from django.conf import settings
@@ -41,6 +42,12 @@ def test_lazy_objects(self):
s4 = ugettext_lazy('Some other string')
self.assertEqual(False, s == s4)
+ def test_lazy_pickle(self):
+ s1 = ugettext_lazy("test")
+ self.assertEqual(unicode(s1), "test")
+ s2 = pickle.loads(pickle.dumps(s1))
+ self.assertEqual(unicode(s2), "test")
+
def test_string_concat(self):
"""
unicode(string_concat(...)) should not raise a TypeError - #4796
Please sign in to comment.
Something went wrong with that request. Please try again.