Skip to content
This repository

HTTPS clone URL

Subversion checkout URL

You can clone with HTTPS or Subversion.

Download ZIP
Browse code

[1.5.x] Don't use : as an invalid cookie character

Since http://bugs.python.org/issue2193 has been resolved in favour of
the colon in cookie names, we need to test invalid cookie removal using
a different character. "@" is still considered invalid by all sources.

Backport of 419e213 from master
  • Loading branch information...
commit edaacc41124c562961df478be1382773216cac55 1 parent 7b69785
Ian Clelland authored September 28, 2012 spookylukey committed October 26, 2012
2  tests/regressiontests/requests/tests.py
@@ -57,7 +57,7 @@ def test_wsgirequest_repr(self):
57 57
                          str_prefix("<WSGIRequest\npath:/otherpath/,\nGET:{%(_)s'a': %(_)s'b'},\nPOST:{%(_)s'c': %(_)s'd'},\nCOOKIES:{%(_)s'e': %(_)s'f'},\nMETA:{%(_)s'g': %(_)s'h'}>"))
58 58
 
59 59
     def test_parse_cookie(self):
60  
-        self.assertEqual(parse_cookie('invalid:key=true'), {})
  60
+        self.assertEqual(parse_cookie('invalid@key=true'), {})
61 61
 
62 62
     def test_httprequest_location(self):
63 63
         request = HttpRequest()

0 notes on commit edaacc4

Please sign in to comment.
Something went wrong with that request. Please try again.