Skip to content

HTTPS clone URL

Subversion checkout URL

You can clone with HTTPS or Subversion.

Download ZIP
Browse files

Folded BaseHandler.get_friendly_error_response() into BaseHandler.get…

…_response() to save the overhead of a function call, and because that logic didn't need to be abstracted.

git-svn-id: http://code.djangoproject.com/svn/django/trunk@3878 bcc190cf-cafb-0310-a4f2-bffc1f526a37
  • Loading branch information...
commit f22cd4ec05f924725af2b634ab206bc99fbe543d 1 parent f638234
Adrian Holovaty adrianholovaty authored
Showing with 3 additions and 9 deletions.
  1. +3 −9 django/core/handlers/base.py
12 django/core/handlers/base.py
View
@@ -112,15 +112,9 @@ def get_response(self, request):
request_repr = "Request repr() unavailable"
message = "%s\n\n%s" % (self._get_traceback(exc_info), request_repr)
mail_admins(subject, message, fail_silently=True)
- return self.get_friendly_error_response(request, resolver)
-
- def get_friendly_error_response(self, request, resolver):
- """
- Returns an HttpResponse that displays a PUBLIC error message for a
- fundamental error.
- """
- callback, param_dict = resolver.resolve500()
- return callback(request, **param_dict)
+ # Return an HttpResponse that displays a friendly error message.
+ callback, param_dict = resolver.resolve500()
+ return callback(request, **param_dict)
def get_technical_error_response(self, request, is404=False, exception=None):
"""
Please sign in to comment.
Something went wrong with that request. Please try again.