Browse files

Fixed #3281 -- newforms: URLField now works properly with required=Fa…

…lse and verify_exists=True together. Thanks, zendak

git-svn-id: http://code.djangoproject.com/svn/django/trunk@4313 bcc190cf-cafb-0310-a4f2-bffc1f526a37
  • Loading branch information...
1 parent 6b31f95 commit f2a3deb0871c6cdbe04e1e0b36f4984c7c825bac @adrianholovaty adrianholovaty committed Jan 13, 2007
Showing with 7 additions and 0 deletions.
  1. +2 −0 django/newforms/fields.py
  2. +5 −0 tests/regressiontests/forms/tests.py
View
2 django/newforms/fields.py
@@ -288,6 +288,8 @@ def __init__(self, max_length=None, min_length=None, required=True, verify_exist
def clean(self, value):
value = RegexField.clean(self, value)
+ if not self.required and value == u'':
+ return value
if self.verify_exists:
import urllib2
from django.conf import settings
View
5 tests/regressiontests/forms/tests.py
@@ -1331,6 +1331,11 @@
Traceback (most recent call last):
...
ValidationError: [u'This URL appears to be a broken link.']
+>>> f = URLField(verify_exists=True, required=False)
+>>> f.clean('')
+u''
+>>> f.clean('http://www.google.com') # This will fail if there's no Internet connection
+u'http://www.google.com'
EmailField also access min_length and max_length parameters, for convenience.
>>> f = URLField(min_length=15, max_length=20)

0 comments on commit f2a3deb

Please sign in to comment.