Browse files

Increased memoization cache size for language codes.

There may be more than 100 (default maxsize) commonly seen xx-yy values
on some sites. The additional memory consumption isn't significant.

Also added a comment explaining why this cache must have a maxsize.
  • Loading branch information...
1 parent e819a3c commit f356b6ecc3fe15634d504690c1793460e5fe9bee @aaugustin aaugustin committed Mar 29, 2014
Showing with 5 additions and 1 deletion.
  1. +5 −1 django/utils/translation/
6 django/utils/translation/
@@ -389,12 +389,16 @@ def all_locale_paths():
return [globalpath] + list(settings.LOCALE_PATHS)
def check_for_language(lang_code):
Checks whether there is a global language file for the given language
code. This is used to decide whether a user-provided language is
+ lru_cache should have a maxsize to prevent from memory exhaustion attacks,
+ as the provided language codes are taken from the HTTP request. See also
+ <>.
# First, a quick check to make sure lang_code is well-formed (#21458)
if not

0 comments on commit f356b6e

Please sign in to comment.