Skip to content

HTTPS clone URL

Subversion checkout URL

You can clone with HTTPS or Subversion.

Download ZIP
Browse files

Fixed #1477: URLFields now accept a maxlength parameter. Thanks, Matt…

… Croydon.

git-svn-id: http://code.djangoproject.com/svn/django/trunk@4295 bcc190cf-cafb-0310-a4f2-bffc1f526a37
  • Loading branch information...
commit f6390e8983dd364053078cc80361cb369b667690 1 parent 0421b25
@jacobian jacobian authored
View
1  django/db/backends/ado_mssql/creation.py
@@ -21,6 +21,5 @@
'SmallIntegerField': 'smallint',
'TextField': 'text',
'TimeField': 'time',
- 'URLField': 'varchar(200)',
'USStateField': 'varchar(2)',
}
View
1  django/db/backends/mysql/creation.py
@@ -25,6 +25,5 @@
'SmallIntegerField': 'smallint',
'TextField': 'longtext',
'TimeField': 'time',
- 'URLField': 'varchar(200)',
'USStateField': 'varchar(2)',
}
View
1  django/db/backends/oracle/creation.py
@@ -21,6 +21,5 @@
'SmallIntegerField': 'smallint',
'TextField': 'long',
'TimeField': 'timestamp',
- 'URLField': 'varchar(200)',
'USStateField': 'varchar(2)',
}
View
1  django/db/backends/postgresql/creation.py
@@ -25,6 +25,5 @@
'SmallIntegerField': 'smallint',
'TextField': 'text',
'TimeField': 'time',
- 'URLField': 'varchar(200)',
'USStateField': 'varchar(2)',
}
View
1  django/db/backends/sqlite3/creation.py
@@ -24,6 +24,5 @@
'SmallIntegerField': 'smallint',
'TextField': 'text',
'TimeField': 'time',
- 'URLField': 'varchar(200)',
'USStateField': 'varchar(2)',
}
View
8 django/db/models/fields/__init__.py
@@ -800,16 +800,20 @@ def flatten_data(self,follow, obj = None):
def formfield(self, initial=None):
return forms.TimeField(required=not self.blank, label=capfirst(self.verbose_name), initial=initial)
-class URLField(Field):
+class URLField(CharField):
def __init__(self, verbose_name=None, name=None, verify_exists=True, **kwargs):
+ kwargs['maxlength'] = kwargs.get('maxlength', 200)
if verify_exists:
kwargs.setdefault('validator_list', []).append(validators.isExistingURL)
self.verify_exists = verify_exists
- Field.__init__(self, verbose_name, name, **kwargs)
+ CharField.__init__(self, verbose_name, name, **kwargs)
def get_manipulator_field_objs(self):
return [oldforms.URLField]
+ def get_internal_type(self):
+ return "CharField"
+
def formfield(self, initial=None):
return forms.URLField(required=not self.blank, verify_exists=self.verify_exists, label=capfirst(self.verbose_name), initial=initial)
Please sign in to comment.
Something went wrong with that request. Please try again.