Please sign in to comment.
Fixed #20084 -- Provided option to validate formset max_num on server.
This is provided as a new "validate_max" formset_factory option defaulting to False, since the non-validating behavior of max_num is longstanding, and there is certainly code relying on it. (In fact, even the Django admin relies on it for the case where there are more existing inlines than the given max_num). It may be that at some point we want to deprecate validate_max=False and eventually remove the option, but this commit takes no steps in that direction. This also fixes the DoS-prevention absolute_max enforcement so that it causes a form validation error rather than an IndexError, and ensures that absolute_max is always 1000 more than max_num, to prevent surprising changes in behavior with max_num close to absolute_max. Lastly, this commit fixes the previous inconsistency between a regular formset and a model formset in the precedence of max_num and initial data. Previously in a regular formset, if the provided initial data was longer than max_num, it was truncated; in a model formset, all initial forms would be displayed regardless of max_num. Now regular formsets are the same as model formsets; all initial forms are displayed, even if more than max_num. (But if validate_max is True, submitting these forms will result in a "too many forms" validation error!) This combination of behaviors was chosen to keep the max_num validation simple and consistent, and avoid silent data loss due to truncation of initial data. Thanks to Preston for discussion of the design choices.
- Loading branch information...
Showing with 210 additions and 47 deletions.
- +3 −2 django/contrib/contenttypes/generic.py
- +20 −10 django/forms/formsets.py
- +5 −3 django/forms/models.py
- +1 −1 docs/ref/contrib/contenttypes.txt
- +16 −0 docs/ref/forms/formsets.txt
- +1 −0 docs/ref/forms/index.txt
- +8 −7 docs/ref/forms/models.txt
- +8 −0 docs/releases/1.6.txt
- +69 −9 docs/topics/forms/formsets.txt
- +4 −3 docs/topics/forms/modelforms.txt
- +48 −12 tests/forms_tests/tests/formsets.py
- +27 −0 tests/model_formsets/tests.py
|@@ -0,0 +1,16 @@|
|+.. module:: django.forms.formsets|
|+ :synopsis: Django's functions for building formsets.|
|+.. function:: formset_factory(form, formset=BaseFormSet, extra=1, can_order=False, can_delete=False, max_num=None, validate_max=False)|
|+ Returns a ``FormSet`` class for the given ``form`` class.|
|+ See :ref:`formsets` for example usage.|
|+ .. versionchanged:: 1.6|
|+ The ``validate_max`` parameter was added.|