Skip to content


Subversion checkout URL

You can clone with
Download ZIP
Browse files

Fixed #17046 -- Added a check if the username passed to User.objects.…

…create_user is empty or not. Thanks, kwadrat.

git-svn-id: bcc190cf-cafb-0310-a4f2-bffc1f526a37
  • Loading branch information...
1 parent 40b248a commit fcaf8eae14d0a7f884328bdf0238dd1e2881c681 @jezdez jezdez committed
2  django/contrib/auth/
@@ -149,6 +149,8 @@ def create_user(self, username, email=None, password=None):
Creates and saves a User with the given username, email and password.
now =
+ if not username:
+ raise ValueError('The given username must be set')
email = UserManager.normalize_email(email)
user = self.model(username=username, email=email,
is_staff=False, is_active=True, is_superuser=False,
5 django/contrib/auth/tests/
@@ -91,3 +91,8 @@ def test_create_user_email_domain_normalize(self):
def test_create_user_email_domain_normalize_with_whitespace(self):
returned = UserManager.normalize_email('email\ with_whitespace@D.COM')
self.assertEquals(returned, 'email\')
+ def test_empty_username(self):
+ self.assertRaisesMessage(ValueError,
+ 'The given username must be set',
+ User.objects.create_user, username='')
4 docs/topics/auth.txt
@@ -280,7 +280,9 @@ Manager functions
.. method:: models.UserManager.create_user(username, email=None, password=None)
.. versionchanged:: 1.4
- The ``email`` parameter was made optional.
+ The ``email`` parameter was made optional. The username
+ parameter is now checked for emptiness and raises a
+ :exc:`ValueError` in case of a negative result.
Creates, saves and returns a :class:`~django.contrib.auth.models.User`.

0 comments on commit fcaf8ea

Please sign in to comment.
Something went wrong with that request. Please try again.