Skip to content
Browse files

[1.7.x] Fixed #23008 -- Fixed typo causing bad migration dependencies.

Thanks semenov for the report and Florian for investigation.

Backport of 9a2ab62 from master
  • Loading branch information...
1 parent f2011e2 commit fe5f29eb1db795257d4095df0e1547c17daadade @timgraham timgraham committed
Showing with 3 additions and 3 deletions.
  1. +2 −2 django/db/migrations/
  2. +1 −1 tests/migrations/
4 django/db/migrations/
@@ -254,13 +254,13 @@ def _detect_changes(self, convert_apps=None, graph=None):
# If we can't find the other app, we add a first/last dependency,
# but only if we've already been through once and checked everything
if chop_mode:
- # If the app already exists, we add __last__, as we don't know which
+ # If the app already exists, we add __latest__, as we don't know which
# migration contains the target field.
# If it's not yet migrated or has no migrations, we use __first__
if graph and not graph.root_nodes(dep[0]):
operation_dependencies.add((dep[0], "__first__"))
- operation_dependencies.add((dep[0], "__last__"))
+ operation_dependencies.add((dep[0], "__latest__"))
deps_satisfied = False
if deps_satisfied:
2 tests/migrations/
@@ -1045,4 +1045,4 @@ def test_last_dependency(self):
self.assertOperationTypes(changes, 'otherapp', 0, ["CreateModel"])
self.assertOperationAttributes(changes, 'otherapp', 0, 0, name="Book")
# Right dependencies?
- self.assertEqual(changes['otherapp'][0].dependencies, [("migrations", "__last__")])
+ self.assertEqual(changes['otherapp'][0].dependencies, [("migrations", "__latest__")])

0 comments on commit fe5f29e

Please sign in to comment.
Something went wrong with that request. Please try again.