New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Forgotten snippet in `mysite/urls.py` added #10002

Closed
wants to merge 2 commits into
base: master
from

Conversation

Projects
None yet
2 participants
@Jihadik

Jihadik commented May 28, 2018

Without the step I added in a new snippet nothing was working, since path('polls/', include('polls.urls')), wasn't there, hence Django was unaware of urlpatterns inside polls/urls.py.

Jihadik added some commits May 28, 2018

Forgotten snippet in `mysite/urls.py` added
Without the step I added in a new snippet nothing was working, since `path('polls/', include('polls.urls')),` wasn't there, hence Django was unaware of `urlpatterns` inside `polls/urls.py`.
Forgotten import
One more typo in tutorial 3.
@@ -98,6 +101,17 @@ Wire these new views into the ``polls.urls`` module by adding the following
path('<int:question_id>/vote/', views.vote, name='vote'),
]
.. snippet::

This comment has been minimized.

@timgraham

timgraham May 28, 2018

Member

This was already done in tutorial 1.

This comment has been minimized.

@Jihadik

Jihadik May 28, 2018

Amazing, how I've missed it!

@@ -66,6 +66,9 @@ slightly different, because they take an argument:
.. snippet::
:filename: polls/views.py
from django.http import HttpResponse

This comment has been minimized.

@timgraham

timgraham May 28, 2018

Member

This import was already added in tutorial 1. The instructions say to add these views.

@Jihadik Jihadik closed this May 28, 2018

@Jihadik Jihadik deleted the Jihadik:patch-1 branch May 28, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment