Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updated GIS install instructions to use placeholders for GIS library versions. #10036

Merged
merged 1 commit into from Jun 12, 2018

Conversation

brylie
Copy link
Contributor

@brylie brylie commented Jun 8, 2018

GEOS 3.4.2 reportedly does not work fully as expected. Bump GEOS recommended version to 3.6.2.

https://www.reddit.com/r/django/comments/8pim8i/how_do_i_request_an_edit_in_the_geodjango/

@timgraham timgraham changed the title Use GEOS 3.6.2 Updated GIS install instructions to use the latest versions of GIS libraries. Jun 8, 2018
@timgraham
Copy link
Member

Could you also bump the versions of the other packages on this page?

@claudep
Copy link
Member

claudep commented Jun 9, 2018

Shouldn't this snippet written with a placeholder (like <latest version>) instead of hardcoding a version number?

GEOS 3.4.2 reportedly does not work fully as expected

What's the issue?

@brylie
Copy link
Contributor Author

brylie commented Jun 9, 2018

Shouldn't this snippet written with a placeholder (like ) instead of hardcoding a version number?

That would seem like a reasonable idea. How could the latest-version be inserted into the tutorial? E.g. we could keep a list of latest version for the libraries, and the documentation pre-build script would insert their values throughout the article(s) where relevant.

@claudep
Copy link
Member

claudep commented Jun 9, 2018

Something like First, download a Django-supported GEOS archive from the GEOS website... and then a litteral <version> string in the lines below? I don't think inserting a real version number is worth the trouble.

@brylie
Copy link
Contributor Author

brylie commented Jun 9, 2018

Well, I think it is done so people can copy/paste the commands. That makes it easier to get started.

Another idea would be to maintain a basic installation script, so users could just run the script instead of a series of commands.

@claudep
Copy link
Member

claudep commented Jun 9, 2018

In my opinion, building from source is not for the faint-hearted, but for relatively experienced devs, that's why I think they are able to make the version replacement themselves.

@timgraham
Copy link
Member

I'd be in favor of placeholders also.

@timgraham timgraham changed the title Updated GIS install instructions to use the latest versions of GIS libraries. Updated GIS install instructions to use placeholders for GIS library versions. Jun 12, 2018
@timgraham timgraham merged commit ae26e0a into django:master Jun 12, 2018
@brylie brylie deleted the patch-1 branch June 13, 2018 09:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants