Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed #28291, #24726 -- Fixed ArrayField with JSONField and RangeFields. #10222

Merged
merged 1 commit into from Jul 27, 2018

Conversation

Projects
None yet
2 participants

@vinayinvicible vinayinvicible force-pushed the vinayinvicible:ticket_28291 branch from ac7e6fa to 6488863 Jul 24, 2018

@vinayinvicible vinayinvicible changed the title Refs #28291 -- Made JSONField compatible with ArrayField Refs #28291 & #24726 -- Made ArrayField compatible with non trivial database types Jul 24, 2018

@timgraham
Copy link
Member

left a comment

Are new models needed? Maybe you can add fields to OtherTypesArrayModel?

@@ -54,6 +55,13 @@ def test_dates(self):
self.assertEqual(instance.dates, loaded.dates)
self.assertEqual(instance.times, loaded.times)

def test_json(self):
instance = JSONArrayModel(field=[{'a': 1}, {'b': 2}])

This comment has been minimized.

Copy link
@timgraham

timgraham Jul 25, 2018

Member

I would use .objects.create() rather than separate save calls.

@vinayinvicible vinayinvicible force-pushed the vinayinvicible:ticket_28291 branch from 1e74715 to 39c99d3 Jul 26, 2018

@vinayinvicible

This comment has been minimized.

Copy link
Contributor Author

commented Jul 26, 2018

@timgraham made required changes.

@timgraham timgraham force-pushed the vinayinvicible:ticket_28291 branch from 39c99d3 to 13ba81f Jul 27, 2018

@timgraham timgraham changed the title Refs #28291 & #24726 -- Made ArrayField compatible with non trivial database types Fixed #28291, #24726 -- Fixed ArrayField with JSONField and RangeFields. Jul 27, 2018

@timgraham timgraham merged commit 3af695e into django:master Jul 27, 2018

16 of 18 checks passed

pr-mariadb/database=mysql,label=mariadb,python=python3.7 Build #202 ended
Details
pr-mariadb/database=mysql_gis,label=mariadb,python=python3.7 Build #202 ended
Details
docs Build #15576 ended
Details
flake8 Build #15681 ended
Details
isort Build #15713 succeeded in 16 sec
Details
pull-requests-bionic/database=mysql,label=bionic-pr,python=python3.6 Build #695 ended
Details
pull-requests-bionic/database=mysql_gis,label=bionic-pr,python=python3.6 Build #695 ended
Details
pull-requests-bionic/database=postgis,label=bionic-pr,python=python3.6 Build #695 ended
Details
pull-requests-bionic/database=postgres,label=bionic-pr,python=python3.6 Build #695 ended
Details
pull-requests-bionic/database=spatialite,label=bionic-pr,python=python3.6 Build #695 ended
Details
pull-requests-bionic/database=sqlite3,label=bionic-pr,python=python3.6 Build #695 ended
Details
pull-requests-javascript Build #12072 ended
Details
pull-requests-windows/database=sqlite3,label=windows,python=Python35 Build #7749 ended
Details
pull-requests-xenial/database=mysql_gis,label=xenial,python=python3.5 Build #644 ended
Details
pull-requests-xenial/database=postgis,label=xenial,python=python3.5 Build #644 ended
Details
pull-requests-xenial/database=postgres,label=xenial,python=python3.5 Build #644 ended
Details
pull-requests-xenial/database=spatialite,label=xenial,python=python3.5 Build #644 ended
Details
pull-requests-xenial/database=sqlite3,label=xenial,python=python3.5 Build #644 ended
Details

@vinayinvicible vinayinvicible deleted the vinayinvicible:ticket_28291 branch Jul 27, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.