Fixed #28606 -- Deprecated CachedStaticFilesStorage. #10570
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
charettes
approved these changes
Oct 27, 2018
| @override_settings( | ||
| STATICFILES_STORAGE='django.contrib.staticfiles.storage.CachedStaticFilesStorage', | ||
| ) | ||
| class TestCollectionCachedStorage(TestHashedFiles, CollectionTestCase): | ||
| """ | ||
| Tests for the Cache busting storage | ||
| """ | ||
| @ignore_warnings(category=RemovedInDjango31Warning) |
There was a problem hiding this comment.
Is this required given the class is already decorated?
| @@ -282,6 +282,7 @@ def test_cache_key_memcache_validation(self): | |||
| cache_validator.validate_key(cache_key) | |||
| self.assertEqual(cache_key, 'staticfiles:821ea71ef36f95b3922a77f7364670e7') | |||
|
|
|||
| @ignore_warnings(category=RemovedInDjango31Warning) | |||
There was a problem hiding this comment.
Is this required given the class is already decorated?
| class TestCachedStaticFilesStorageDeprecation(SimpleTestCase): | ||
| def test_warning(self): | ||
| from django.contrib.staticfiles.storage import CachedStaticFilesStorage | ||
| from django.utils.deprecation import RemovedInDjango31Warning |
There was a problem hiding this comment.
I guess these imports were moved here for easier removal once the deprecation period ends?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://code.djangoproject.com/ticket/28606