Oracle fixes #1071

Closed
wants to merge 5 commits into from

1 participant

@shaib

Fix for the Django Oracle backend's slow handling of numbers.

unknown and others added some commits Aug 29, 2012
unknown Removed the slow _rowfactory function and replaced it with a cx_Oracl…
…e 5 outputtypehandler function that operates only on each column, instead of each returned value.
6198b41
@shaib shaib Fix to _outputtypehandler fix: Use module-level function instead of m…
…ethod

(because using a method ends up leaking cursors)
while at it: rename to_unicode ==> _to_unicode to conform with file's standard
f8c0372
@shaib shaib Fix for Oracle performance fix: improve performance on decimals deff497
@shaib shaib Documentation: update cx_Oracle requirement to 5.0.1 3cc5624
Shai Berger Merge branch 'master' of git://github.com/django/django 9e5f6fa
@timgraham timgraham commented on the diff Jun 17, 2013
docs/releases/1.5.txt
@@ -669,6 +669,7 @@ Miscellaneous
needs. The new default value is ``0666`` (octal) and the current umask value
is first masked out.
+
@timgraham
Django member

try not to make whitespace changes in random files

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
@timgraham timgraham commented on the diff Jun 17, 2013
docs/ref/databases.txt
.. _`Oracle Database Server`: http://www.oracle.com/
.. _`cx_Oracle`: http://cx-oracle.sourceforge.net/
+
@timgraham
Django member

we usually have just 1 newline between sections in the docs

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
@timgraham timgraham commented on the diff Jun 17, 2013
docs/ref/databases.txt
``WITH_UNICODE`` environment variable. This is recommended but not
required.
+.. versionchanged:: 1.6
+
+Django 1.6 changed the required `cx_Oracle`_ version from 4.3.1 to 5.0.1.
@timgraham
Django member

add this to docs/release/1.6.txt?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
@timgraham timgraham commented on the diff Jun 17, 2013
django/db/backends/oracle/base.py
@@ -910,6 +882,21 @@ def to_unicode(s):
return s
+def _decimal_or_int(value,
+ D=decimal.Decimal):
@timgraham
Django member

doesn't seem like this needs to be broken up into two lines

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
@shaib

Sorry Tim -- I should have closed this earlier, when I realized something funny was going on.

I am working on a completely different approach. Details forthcoming.

@shaib shaib closed this Jun 17, 2013
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment